Skip to content

chore: remove "VPN" from setting description #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

chore: remove "VPN" from setting description #86

merged 1 commit into from
Mar 11, 2025

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Mar 2, 2025 •
edited
Loading

Rename "CoderVPN" to "Coder Connect" in UI and system components

  • Updates VPN-related text from "CoderVPN" to "Coder Connect" in UI components
  • Changes network extension references from "VPN" to "NE" in system messages
  • Updates VPN tunnel name from "CoderVPN" to "Coder" in network configuration
  • Modifies installation scripts to use "Coder" as the VPN service name

@ThomasK33 Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 requested a review from ethanndickson March 2, 2025 15:49
@ThomasK33 ThomasK33 self-assigned this Mar 2, 2025
@ThomasK33 ThomasK33 marked this pull request as ready for review March 2, 2025 15:50
@ethanndickson
Copy link
Member

Do we want to change it in the UI too?

@ThomasK33 ThomasK33 force-pushed the thomask33/03-02-chore_remove_vpn_from_setting_description branch from 4405af0 to f99d936 Compare March 3, 2025 09:48
@ThomasK33 ThomasK33 marked this pull request as draft March 3, 2025 12:14
@ethanndickson ethanndickson removed their request for review March 6, 2025 03:26
@ThomasK33 ThomasK33 force-pushed the thomask33/03-02-chore_remove_vpn_from_setting_description branch from f99d936 to 17da969 Compare March 7, 2025 09:38
@ThomasK33 ThomasK33 marked this pull request as ready for review March 7, 2025 09:39
@ThomasK33 ThomasK33 linked an issue Mar 7, 2025 that may be closed by this pull request
Rename CoderVPN to Coder (Connect) in UI coder/internal#458
Closed
2 tasks
ethanndickson
ethanndickson approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more in Views/Settings/LiteralHeadersSection.swift, I had it incorrectly as Coder VPN (with a space)

@ThomasK33
chore: remove "VPN" from setting description
3579523 
Change-Id: If1e0c81dd7188eea92f814424a997944a07caf86
Signed-off-by: Thomas Kosiewski <[email protected]>
@ThomasK33 ThomasK33 force-pushed the thomask33/03-02-chore_remove_vpn_from_setting_description branch from 17da969 to 3579523 Compare March 11, 2025 09:11
@ThomasK33 Graphite App
Copy link
Member Author

ThomasK33 commented Mar 11, 2025 •
edited
Loading

Merge activity

  • Mar 11, 5:44 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 11, 5:44 AM EDT: A user merged this pull request with Graphite.

@ThomasK33 ThomasK33 merged commit 2094e9f into main Mar 11, 2025
4 checks passed
@ThomasK33 ThomasK33 deleted the thomask33/03-02-chore_remove_vpn_from_setting_description branch March 11, 2025 09:44
@ethanndickson ethanndickson mentioned this pull request Apr 14, 2025
Merged
ethanndickson added a commit that referenced this pull request Apr 15, 2025
@ethanndickson
fix: support old VPN config names in post & pre install scripts (#134)
33da515 
One thing I noticed as part of my work on #121 is that our attempted fix introduced in #92 wasn't working as expected if the user had a VPN configuration installed before #86. 

This PR fetches the unique name of the VPN service dynamically, as part of the script, such that the service is started and stopped regardless of whether the service is called "Coder" or the older "CoderVPN".

This also ensures we don't break it again if we ever change that name, such as to "Coder Connect" (I don't totally recall why it was set to "Coder", but I don't mind it)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@ThomasK33 ThomasK33

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename CoderVPN to Coder (Connect) in UI
2 participants
@ThomasK33 @ethanndickson